Merged
Conversation
The release build jobs need 'contents: write' permissions to be able to update the release.
While convenient it does not follow the rule of minimal privileges
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines CI workflows by replacing inherited secrets with explicit TEST_GITHUB_* secrets and tightening job permissions to enable safe release operations.
- Removed
secrets: inheritand specified explicitTEST_GITHUB_*secrets for relevant jobs - Granted
contents: writepermission to the release notes template and adjusted release job dependencies - Updated CI and release workflows to use explicit secrets for the build-push-test reusable job
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/wc-build-push-test.yml | Removed inherited secrets, added explicit secrets for acceptance-test only |
| .github/workflows/release-build.yml | Added explicit secrets to build-push-test, granted contents write, updated job needs |
| .github/workflows/continuous-integration.yml | Added explicit secrets to build-push-test job |
Comments suppressed due to low confidence (2)
.github/workflows/wc-build-push-test.yml:51
- The integration-test job no longer inherits any secrets but doesn’t specify explicit ones. If it requires authentication (e.g., TEST_GITHUB_TOKEN), add the necessary secrets block to avoid job failures.
uses: ./.github/workflows/wc-integration-test.yml
.github/workflows/release-build.yml:20
- [nitpick] Defining the same set of TEST_GITHUB_* secrets in multiple workflows leads to duplication. Consider centralizing these secrets in a reusable workflow or a shared environment to simplify maintenance.
secrets:
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
Contributor
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 18 | 0 | 0 | 0.62s | |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.86s | |
| ✅ GHERKIN | gherkin-lint | 2 | 0 | 0 | 0.91s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.43s | |
| ✅ JSON | prettier | 16 | 1 | 0 | 0 | 0.49s |
| ✅ JSON | v8r | 16 | 0 | 0 | 7.6s | |
| ✅ MARKDOWN | markdownlint | 9 | 0 | 0 | 0 | 0.89s |
| ✅ MARKDOWN | markdown-table-formatter | 9 | 0 | 0 | 0 | 0.29s |
| ✅ REPOSITORY | checkov | yes | no | no | 16.99s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.41s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| grype | yes | no | 2 | 23.31s | ||
| ✅ REPOSITORY | secretlint | yes | no | no | 0.95s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.9s | |
| ✅ REPOSITORY | trivy | yes | no | no | 6.79s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.23s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 4.47s | |
| ✅ SPELL | lychee | 63 | 0 | 0 | 2.19s | |
| ✅ YAML | prettier | 24 | 0 | 0 | 0 | 0.92s |
| ✅ YAML | v8r | 24 | 0 | 0 | 6.79s | |
| ✅ YAML | yamllint | 24 | 0 | 0 | 0.95s |
See detailed report in MegaLinter reports
Contributor
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
Contributor
EkelmansPh
approved these changes
Jun 24, 2025
|
Contributor
Pull Request Report (#831)Static measures
Time related measures
Status check related measures
|
Contributor
|
🎉 Hooray! The changes in this pull request went live with the release of v6.2.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
This PR fixes permissions for the release jobs. They need to write to the release, and therefor need content: write permissions.
✔️ Checklist